search

ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
66 stars 29 forks source link

Update `bifrost.memory`'s understanding of memory spaces #223

Open jaycedowell opened 1 year ago

jaycedowell commented 1 year ago

~This PR updates the "memset" and "memcpy" functions in bifrost.memory to work with ndarrays that live in non-system accessible spaces.~

This PR removes the deprecated memcpy and memset functions from bifrost.memory.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.19%. Comparing base (898e4a8) to head (98ccc58). Report is 13 commits behind head on master.

:exclamation: Current head 98ccc58 differs from pull request most recent head f9ae42b. Consider uploading reports for the commit f9ae42b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #223 +/- ## ========================================== - Coverage 68.19% 68.19% -0.01% ========================================== Files 65 65 Lines 5515 5486 -29 ========================================== - Hits 3761 3741 -20 + Misses 1754 1745 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jaycedowell commented 1 year ago

These test failures might be related to #220.

jaycedowell commented 7 months ago

It looks like these failures (and some of those part of the testing for https://github.com/ledatelescope/bifrost/pull/166) are related to missing file(s) needed by the extended testbench tests. Maybe we should drop those tests?

jaycedowell commented 6 months ago

I did one more check through code to see if I could find any lingering calls to bifrost.memory.memcpy* or bifrost.memory.memset*. Looks clean. I think this one is ready to go.