search

ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
64 stars 29 forks source link

Add simple packet #225

Closed dentalfloss1 closed 3 months ago

dentalfloss1 commented 5 months ago

Adds a simple packet format with a header composed of just a sequence number and the data being 4094 shorts.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (ibverb-support@0e6d1d8). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ibverb-support #225 +/- ## ================================================= Coverage ? 67.79% ================================================= Files ? 66 Lines ? 5744 Branches ? 0 ================================================= Hits ? 3894 Misses ? 1850 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jaycedowell commented 5 months ago

Two additional thoughts:

  1. If the optimization/intrinsic stuff isn't working it could be because it isn't implemented correctly.
  2. We could consider some kind of loopback-style test of the packet format similar to what is in test.test_disk_io and test.test_udp_io.
dentalfloss1 commented 5 months ago

The optimizations worked when I switched machines. It was probably due to issues with the machine I was using. I'll work on writing tests

edit: no, optimizations are still broken

jaycedowell commented 3 months ago

The tests pass. Maybe it's ready to merge.