Closed benbarsdell closed 7 years ago
Merging #98 into master will decrease coverage by
3.15%
. The diff coverage is60.56%
.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 69.59% 66.43% -3.16%
==========================================
Files 34 39 +5
Lines 3463 3519 +56
==========================================
- Hits 2410 2338 -72
- Misses 1053 1181 +128
Impacted Files | Coverage Δ | |
---|---|---|
python/bifrost/dtype.py | 21.59% <0%> (-12.7%) |
:arrow_down: |
python/bifrost/udp_capture.py | 0% <0%> (ø) |
|
python/bifrost/udp_transmit.py | 0% <0%> (ø) |
|
python/bifrost/linalg.py | 0% <0%> (ø) |
|
python/bifrost/map.py | 19.44% <0%> (ø) |
:arrow_up: |
python/bifrost/Space.py | 83.33% <100%> (-0.88%) |
:arrow_down: |
python/bifrost/proclog.py | 27.27% <100%> (-0.27%) |
:arrow_down: |
python/bifrost/udp_socket.py | 55% <18.18%> (-1%) |
:arrow_down: |
python/bifrost/address.py | 45.45% <30.76%> (-9.1%) |
:arrow_down: |
python/bifrost/device.py | 63.63% <50%> (ø) |
:arrow_up: |
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8d5d922...11fe2c4. Read the comment docs.
Heroic effort, Ben!
I am testing this quickly on AWS and then will merge.
Benchmark running on AWS, all timings look faster.
If the standard deviations look reasonably small, this can probably be included in the paper. The plots are all automatically generated so I can update them easily. We basically just need to run s/\cpyclibrary/ctypesgen/g
on new_main.tex, right?
Coverage increased (+0.1%) to 65.66% when pulling 11fe2c41b660962f712e032fcc2d7e12388cfd87 on replace_pyclibrary_with_ctypesgen into 8d5d922a35334d12c5a991c65b0900b548d9668c on master.