search

leddavis / HLA_DNA_Typing

tool to type HLA alleles using DNA sequencing data
MIT License
0 stars 0 forks source link

Xiaomeng's feedback #4

Open xmduumich opened 1 year ago

xmduumich commented 1 year ago

I really liked that you put all related work in links in the related work folder. It is nice to see where to check for more information.

  1. In homepage the input and output paragraph are merged together. Minor formatting issue.
  2. in the Design_Doc_Spec.png, interface section, I don't quite understand what the word tkinter meant? It can be more meaningful if you can expand.
  3. To my understanding you are trying to compare sample HLA region sequence reads to a reference HLA region and decide if the sample have different allele. I wonder if this is different from currently existing variant callers, and how the users would benefit from using this tool specifically for HLA region. Would you elaborate in the design doc?
  4. It did not specify how much data can be handled at once. Probably a later question, but it would be nice to have a place holder with a vague estimation so that people know not to overload.
leddavis commented 1 year ago

Thank you so much for your feedback! Here are some clarifications: In the DDS doc, I use tkinter as the user interface. In class, tkinter was the user interface that was shown for Python users. Also, there are many HLA typing tools out there! I would definitely expand on this tool's benefits once the implementation is complete :). I think you make a great point about specifying the amount of data that can be handled. I created such small files for my test files, so I don't have a good estimate right now, but I will definitely work to include this!

Thank you so much for your input, I really appreciate it!