leddt / visualstudio-colors-solarized

Visual Studio color schemes based on https://github.com/altercation/solarized
MIT License
711 stars 203 forks source link

ReSharper version of VS2010 themes #3

Closed brantb closed 12 years ago

brantb commented 13 years ago

Here's a R#ized version of the VS2010 themes. I also colored the tool windows (Output, Console, Immediate).

VS2010 and R# have a slightly incompatible method of coloring variables and types. When R#'s syntax highlighting is enabled, the "User Types (Foo)" color settings are ignored in favor of the "ReSharper Foo Identifier" settings. I changed a few the existing User Types colors to match the default R# ones.

I'm not sure how compatible these configs are with 2008/2005. I assume if you imported them it would just ignore the unknown color definitions, but I'm not sure which ones are missing in those versions.

brantb commented 13 years ago

Also, I'm not entirely happy with "ReSharper Field Identifier" and "ReSharper Method Identifier". It uses base1 which is almost indistinguishable from base0 (at least in non-bold Consolas 10pt). I'd rather use something between base1 and base2, but that'd be breaking away from the 16-color Solarized palette.

leddt commented 13 years ago

Wow thanks a lot for this. I'll test it as soon as possible.

As for base1, I believe it's intended to be bolded, which makes it stand-out nicely from non-bold base0.

brantb commented 13 years ago

A few more tweaks after playing with it a bit:

Here's a screenshot with and without R#'s "Color identifiers" setting enabled, and a gist with the source code I used to test.

NJAldwin commented 13 years ago

I really like this fork, but is it only for 2010? In 2008, things seem to work okay, but the ReSharper Todo Item's default (Blue) makes it very hard to read.

brantb commented 13 years ago

I've only tested it in VS2010. VS2008 may lack color definitions for certain types of text, or use a different name for them. Unfortunately I don't have VS2008 installed so I can't give it a try myself -- as you discovered, it should mostly work, but it'll probably need some tweaking.

NJAldwin commented 13 years ago

Right. If I do do any tweaking, I'll submit a pull request. I use 2008 at work and 2010 at home, so I'll try to get them to be as similar as possible.

leddt commented 13 years ago

Hi. I have not been available to review the pull requests lately for personal reasons. I don't think I'll have time to maintain this repository. If either of you would like to become collaborators on this, please let me know.

couellet commented 12 years ago

Wow, in VS2010 this pull request is sick! Good job leddt and brantb!

leddt commented 12 years ago

Hey I really want to merge this in but there is a non-trivial merge conflict with the vssettings files and I'm really short on time. Think you can take a look ?

brantb commented 12 years ago

@leddt That ought to do it.

leddt commented 12 years ago

Great! By the way, thank you for your contributions.

brantb commented 12 years ago

Whoops, somehow that merge went bad...

leddt commented 12 years ago

Indeed. Seems the github ui can't be trusted.

leddt commented 12 years ago

I think I fixed it but make sure to update your branches