Enhance syntax highlighting / coloring

[mario-d-s]

The (light) theme, as generated by the template in this repo, makes heavy use of bold fonts, and very few colors.

I have enhanced the syntax highlighting in my fork, at least for C# so far. See my branch @ https://github.com/mario-d-s/visualstudio-colors-solarized/tree/syntax-coloring

I whipped up an example file containing all significant elements and took screenshots for comparison.

Default coloring

• Most elements use the color yellow
• String literals and integer literals have the same color
• Error and warning squiggles are hard to distinguish
• Bold font usage is distracting and makes code "expand" visually as the parser matches tokens

My version

• Reduced usage of bold fonts, reserved to distinguish between different elements with the same color, e.g. string literal vs. verbatim string literal.
• As string literals should be used judiciously, they have been made orange to make them stand out more.
• Classes, interfaces, value-types (structs), enums and delegates all have different colors. This makes me a lot more productive as I don't have to use intellisense or mouse-hover tooltips to determine what stuff is what.
• Changed error/warning squiggles from red/orange to red/yellow

I would like to open a PR, but I realize this may well be an entirely personal preference and not everyone may want their C# to look like a coloring book. Hence, I open this issue to have a discussion first.

@leddt Is enhancing the syntax highlighting something you want to integrate in your repo? If so, do you agree with my choices for colors or do you want some changes?

If this is something you'd like, I'll also point out there is more work to be done here to enhance other languages and contexts (F#, XML, ASPX, XAML, ....)

[astrolemonade]

What text font are you using ?

[mario-d-s]

@cata0309 I have been using Input for quite some time, which should be the font you see in those screenshots.

[astrolemonade]

Thank you very much

În lun., 21 ian. 2019, 10:32 Mario De Schaepmeester < notifications@github.com a scris:

@cata0309 https://github.com/cata0309 I have been using Input http://input.fontbureau.com/ for quite some time, which should be the font you see in those screenshots.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/leddt/visualstudio-colors-solarized/issues/46#issuecomment-455988063, or mute the thread https://github.com/notifications/unsubscribe-auth/Ah-T8QahBdchAqqPykrV_3_edVnxeww6ks5vFXszgaJpZM4TWkAI .