Quick and dirty fix for design flaw in target scope implementation.

ledermann / rails-settings

Manage settings with Ruby on Rails

MIT License

1k stars 137 forks source link

Quick and dirty fix for design flaw in target scope implementation. #28

Closed yemartin closed 11 years ago

yemartin commented 11 years ago

Hi Georg,

Here is a fix for the issue I mentioned by email, with an accompanying test.

I think a proper fix would require a serious redesign: to stop using (and reusing) the ScopedSettings class itself as a kind of container for the settings of a model, but use instances of a class instead.

Anyway, until then, the proposed fix should plug the leaks.

Cheers, and thanks again for your great work!

Yves-Eric

ledermann commented 11 years ago

Thank you for this patch! You are right, a redesign of this gem would be a nice thing...