search

ledesmablt / spotify-cli

Control Spotify playback on any device through the command line.
MIT License
116 stars 15 forks source link

Add 3.10 support by fixing PyInquirer dependency #25

Closed vinlin24 closed 2 years ago

vinlin24 commented 2 years ago

Users with Python 3.10+ installed face issue #23 caused by the PyInquirer dependency. However, I noticed that this issue is only present in the PyPI release. The official GitHub repository, although not updated for a while, is ahead of this release and supports 3.10, so I simply changed the dependency in setup.py to pull from this repo instead of from PyPI. Expectedly, this affects the files:

I also made a change to cli/spotify.py since the --version flag implemented by click.version_info would fail to detect the package name. I don't know if this issue is unique to my development environment, but I updated the decorator just in case. Users still see the same output, spotify-cli, version X.Y.Z.

ledesmablt commented 2 years ago

Hello @vinlin24 , looks like your changes to the setup.py file aren't acceptable to pypi. Unfortunately I'll have to revert this. Build error linked below.

Am considering just using click or a simpler library instead of pyinquirer, but I don't have the time for it right now. Just voicing out some thoughts in case you or anyone else is up to it!

https://github.com/ledesmablt/spotify-cli/actions/runs/3135206863/jobs/5090622155