search

ledger / ledger-mode

Emacs Lisp files for interacting with the C++Ledger accounting system
GNU General Public License v2.0
381 stars 76 forks source link

Turning off ledger-report-auto-refresh prevents editing a report #270

Open JalapenoGremlin opened 3 years ago

JalapenoGremlin commented 3 years ago

It seems that the ledger-report-auto-refresh setting is convoluted with the leger-report-redo (called by ledger-report-edit-report).

Here is my use case. I do not want every save of every ledger buffer to re-run the current leger-report. I want to be able to edit the current report and run it.

Why does editing the current report requier auto-refersh to be turned on. It seems that these are two distinct and separate functions.

enderw88 commented 3 years ago

i wrote that stuff about 7 years ago. i will look into it soon.

On Sat, Oct 24, 2020 at 06:52 Brian Carlson notifications@github.com wrote:

It seems that the ledger-report-auto-refresh setting is convoluted with the leger-report-redo (called by ledger-report-edit-report).

Here is my use case. I do not want every save of every ledger buffer to re-run the current leger-report. I want to be able to edit the current report and run it.

Why does editing the current report requier auto-refersh to be turned on. It seems that these are two distinct and separate functions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ledger/ledger-mode/issues/270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWWLGFRRFNCTHRDQT56EDSMLLYXANCNFSM4S5THDHQ .

-- Craig, Corona De Tucson, AZ [image: missile_flyout] enderw88.wordpress.com

JalapenoGremlin commented 3 years ago

@enderw88 : Thanks for the code you've written.

I wrote some advice around the functions that I needed and that works just fine. 

(advice-add 'ledger-report-edit-report :around
              (lambda (orig)
                (let ((ledger-report-auto-refresh t))
                  (funcall orig))))