Autocomplete does not work with Corfu

[bradprob]

Hi, auto complete does not work for me in combination with Corfu. Corfu does work in C/C++ mode. Both Corfu and ledger-mode are activated in the ledger buffer.

[purcell]

Please can you be more specific than "does not work?" e.g. can you provide a little snippet to show what are you typing, and where you expect a completion to be available?

[purcell]

FWIW, I use corfu myself and just now tried completing an account name and it worked perfectly.

[bradprob]

I mean that no auto-completion happens. Completion seems not to work at all.

Pressing C-c Tab in the screenshot results in "Foo:Foo"

[bradprob]

I toggled debugger on error (toggle-debug-on-error). Pressing C-c Tab, results in this message:

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
  ledger-fully-complete-xact()
  funcall-interactively(ledger-fully-complete-xact)
  command-execute(ledger-fully-complete-xact)

And this completion in the buffer:

[purcell]

Granted, that's not a great failure mode, but what's happening here is that you're misunderstanding the point of ledger-fully-complete-xact. It looks like the idea is that when you write "Some transaction" in the second transaction (ie. starting another transaction with the same payee) then hit C-c TAB, the prior transaction would be used to complete the first.

Probably you want is to trigger completion-at-point instead (which, in turn, would trigger corfu to use ledger's completion-at-point function). I don't think this bug report is anything to do with corfu, then — you're triggering a non-corfu function directly, so corfu isn't in the mix in your exampe.

[purcell]

I've never used ledger-fully-complete-xact myself btw.

For the benefit of other contributors here, this is where the error comes from, because in this case (ledger-thing-at-point) returns 'posting, so the block here is never executed.

[bradprob]

Thanks for the reply! Indeed I misunderstood the function of ledger-fully-complete-xact.