Attempt to fix flaky ledger-fontify/test-017 on Emacs 25.1

ledger / ledger-mode

Emacs Lisp files for interacting with the C++Ledger accounting system

GNU General Public License v2.0

377 stars 75 forks source link

Attempt to fix flaky ledger-fontify/test-017 on Emacs 25.1 #425

Closed bcc32 closed 4 months ago

bcc32 commented 5 months ago

I'm not sure why this fix would be necessary, but it seems to make the CI happy. (I would think ledger-fontify-extend-region should be sufficient to make fontification work reliably, but it's possible Emacs 25.1 is doing something differently).

bcc32 commented 5 months ago

Guess I jinxed it. CI passed on my fork but not here, so it's definitely something fishy going on.

purcell commented 5 months ago

Since it's in a test about fontification, perhaps it would help to somehow force a font lock update, or disable jit-lock-mode... I haven't really dug into this code, sorry.

bcc32 commented 4 months ago

Well, it seems just calling font-lock-ensure a second time prevents the failures. At least, I re-ran the Emacs 25.1 job five times by hand, and it succeeded each time. Maybe good enough for now?