ledger / ledger.github.io

The source code behind https://ledger-cli.org

9 stars 18 forks source link

Fix GitHub actions build #53

Closed afh closed 1 year ago

afh commented 1 year ago

@peterkeen and @tbm this PR is now ready for review. Hopefully I've been able to clean-up the commit history so that why changes were is self-explanatory. If it isn't please ask; I'm happy to answer any questions.

The changes in commit 014b80ed is tested when this PR is merged to master. If you'd like to take any precautions prior to doing that I'm happy to think about how that may be achieved.

⚠️ Nota Bene

[x] This PR depends on ledger#2208 to have been merged. Once it has this PR needs to be updated so that commit e6b2f3aa8 is reverted/removed from this PR.

tbm commented 1 year ago

Note that I applied the change on the ledger side so one commit needs to be reverted

afh commented 1 year ago

Thanks @peterkeen and @tbm for your review. I've reverted the e6b2f3aa8 commit and the files needed to generate version.texi have been fetched from ledger/ledger@master in the latest GitHub Actions build.

@peterkeen I'm uncertain how to test the deployment, happy to bounce around ideas, and happy to coordinate a point in time where we both are online (I reside in CET) and can potentially establish synchronous communication to resolve unexpected issues more directly in case things go wrong.

afh commented 1 year ago

☝️ This PR contains an important security fix (upgrade rack to 2.2.6.3) recommended by dependabot, for details see #57.

tbm commented 1 year ago

I think that was ready to be merged.

afh commented 1 year ago

Thanks for merging, @tbm!