ledger / vim-ledger

Vim plugin for Ledger
GNU General Public License v2.0
370 stars 56 forks source link

Fix for trailing CR character with omni completion on Windows. #152

Closed syringus closed 4 months ago

syringus commented 8 months ago

Fixes #151.

syringus commented 8 months ago

Of course. This was not my intention. I made a mistake and commited my experiments with balance and register commands to this branch.

Now I am not sure how to proceed. Should I close this PR and create a new one containing only the split fixes? Or adding new commit to this PR that reverts changes in last commit (balance and register commands) is better approach?

Thanks. Martin

alerque commented 8 months ago

No need to close this, just shuffle things around.

Untested from memory, but you'll want something like this:

# Save your current state in a new branch
git branch extra-commands

# Reset your current branch to the previous commit
git reset --hard HEAD^

# Push the new (now reset) state of this branch back here
git push --force

# Switch to your other branch to keep working on that
git switch extra-commands

# Push the new branch and open a new PR for it
git push
syringus commented 8 months ago

Great, thanks.

I will do it next week, when I'm back at home.