Review "advanced alignment mode" commits for workable contributions

ledger / vim-ledger

Vim plugin for Ledger

GNU General Public License v2.0

372 stars 55 forks source link

Review "advanced alignment mode" commits for workable contributions #95

Open alerque opened 4 years ago

alerque commented 4 years ago

This set of commits from @dedmons has some interesting ideas, adding here as a PR to consider for possible inclusion and/or reworking.

dedmons commented 4 years ago

Hey @alerque. Sorry for the super long delay in replying.

I am more than happy for this to get merged in and fixed up for other commodities.

Do you need me to open a PR or can this get converted into one?

alerque commented 4 years ago

Hey no worries on the timing. This PR is against your master branch so anything you do there will show up here. This would probably require rebasing your master branch to be productive. If you'd rather work on a new branch taken from the current master and cherry pick or merge into that you can submit that as a separate PR. Either way let me know if there is anything I can do to help.