search

ledger123 / runmyaccounts

SQL-Ledger Customizations by Run My Accounts
GNU General Public License v2.0
16 stars 9 forks source link

Language is not saved #290

Closed sweitmann closed 2 years ago

sweitmann commented 2 years ago

Hi Armaghan,

When you select a language in the appropriate dropdown in a sales or vendor invoice and then post it, the selected language will be saved and displayed again next time you open that invoice again:

Bildschirmfoto 2022-01-23 um 09 25 43

This only works in sales and vendor invoices. Not in quotations, orders and AR/AP-transactions.

Would it be possible to add this feature to those as well?

Regards

ledger123 commented 2 years ago

Hi Sebastian,

This has been fixed and pushed to the github in the attached commit.

Regards

sweitmann commented 2 years ago

Hi Armaghan,

Thanks for fixing this. Unfortunately we now have another small issue.

In the master version when I change the customer, the language version is updated according to the settings in the customer master data.

After your fix this feature seems to be broken, because now it does not change the language even when I switch the customer and the new customer has other language settings in his master data.

It would be great if we could have both. That is:

a.) Language is set according to master data and

b.) if the language is changed it will be remembered/ set accordingly for that invoice or transaction.

Would this be possible?

Regards

ledger123 commented 2 years ago

Hi Sebastian,

It is fixed as needed and I have tested it in both invoices and transactions.

Kindly test at your convenience.

Regards

phkroll commented 2 years ago

merged to dev.