ledger123 / runmyaccounts

SQL-Ledger Customizations by Run My Accounts
GNU General Public License v2.0
16 stars 9 forks source link

Add GL Transaction - Line Tax - Input Screen Adjustments #325

Closed sweitmann closed 1 year ago

sweitmann commented 2 years ago

Hi Armaghan,

As discussed on Nextcloud we would like to make some adjustments to the line tax 'General Ledger--Add Transaction' input screen.

The first adjustment would be to simplify the entry screen by removing the Memo/ Source and Project fields and adding a checkbox, so that second rows with Memo/ Source and Project fields are only displayed if the checkbox is marked. The same way as this is done in for example the 'AR--Sales Invoice' input screen:

Bildschirmfoto 2022-06-14 um 11 03 23 Bildschirmfoto 2022-06-14 um 11 07 16

Regards

ledger123 commented 2 years ago

Hi Sebastian,

This change has been made and pushed to git hub in 325_ branch.

You can also test on our common server where this branch is current branch.

Regards

sweitmann commented 2 years ago

Hi Armaghan,

Amazing! Wonderful how nice and clean the input screen has become. I'm impressed how fast you could solve this.

Next step: I have not quite figured out when the project dropdown occurs and when it doesn't, I just know that sometimes it does and sometimes it doesn't. Could you please check the code and see if you can see the logic and let me know why it doesn't always appear when I mark the checkbox in a single row?

Bildschirmfoto 2022-06-15 um 13 43 18

And if it's not too much hassle, can it be aligned with the Credit entry field above?

Regards

sweitmann commented 2 years ago

Update: I just figured it out and it makes sense. If you don't enter anything in Debit or Credit fields and update, the project field will appear. If you enter a number in Debit or Credit and then update, it will not appear. This logic is fine and thus no need for further action in regard to the projects dropdown, thanks.

If you could just check the alignment that would be great.

Regards

ledger123 commented 2 years ago

Hi Sebastian,

Alignment is corrected by moving the project input to the correct column layout. Kindly have a look on our server and then I shall commit the change.

Regards

sweitmann commented 2 years ago

Hi Armaghan,

Thanks, looks great. And could you please also realign the "Tax Amount" field as discussed yesterday? That would be fantastic, thank you.

Bildschirmfoto 2022-06-17 um 11 18 09

Regards

sweitmann commented 2 years ago

Hi Armaghan,

Thanks for sorting out the alignment. Looks fantastic!

And if you could just also blind out " / Memo / Source" and "/ Project" when the checkbox is not checked, as we discussed the other day, that would be fabulous.

Regards