search

ledger123 / runmyaccounts

SQL-Ledger Customizations by Run My Accounts
GNU General Public License v2.0
16 stars 9 forks source link

VAT-Tax rates #405

Closed raphaelroos closed 12 months ago

raphaelroos commented 1 year ago

Add a column vatkey in the tax table. The column should be of type char(5).

Add a column formdigit in the tax table. The column should be of type number.

Add a column validFrom in the tax table. The column should be of type date.

The IBP team need to be able to read and write these columns via SQL-Ledger https://infoniqa.atlassian.net/wiki/spaces/PDCH/pages/327090323/SQL-Ledger+Dependencies#VAT-Tax-rates---to-do-by-sql-ledger-team

ledger123 commented 1 year ago

These columns are also added.

For both 404 and 405 changes, you need to run this sql on the database.

ALTER TABLE chart ADD curr VARCHAR(3); ALTER TABLE tax ADD vatkey VARCHAR(5); ALTER TABLE tax ADD formdigit NUMERIC(12,2) DEFAULT 0; ALTER TABLE tax ADD validfrom DATE;

Once all testing is done, I shall convert these sql statements into upgrade script in sql folder.

Please also note that this fix for Taxes management does not seem to be merged in develop. It is important to merge before testing so that this screen works correctly:

https://github.com/ledger123/runmyaccounts/issues/397

Here is screenshot of changes with new column:

image

ledger123 commented 1 year ago

Hi,

Upgrade script also added for both tickets and commit is attached to this ticket above.

Regards

ledger123 commented 12 months ago

Hi,

If all is ok, you can close this ticket.

Regards