[IBP-326: LineTax] - Ledger calculations are different from the VAT calculation

[MariaHashimi]

while testing the LineTax, we have noticed that Ledger calculations are different from the VAT calculations.

This means: When a booking is created via Ledger and the user changes the Linetax amount manually (you don't let ledger calculate it) and then save the booking. The tax amounts is recalculated by ledger and is overwritten.

The manually changed amount is stored but not displayed when the booking is opened. In the journal and Linetax report, the changed amount.

This is quite confusing for the accountants/users in their daily workflow and when they have to control the VAT.

Sebastian informed us that you and him have found a solution for that but he did not know if the solution was already implemented by you or not.

[ledger123]

Hi Maria,

Good afternoon,

I have pushed a commit to fix this issue. Kindly test and confirm.

Just as a little precaution, please test this thoroughly with all possible scenarios with or without linetax as code for transactions is quite complicated and we need to be sure that all is ok before merging.

Regards

[MariaHashimi]

Hi @ledger123, During the testing, we noticed that the VAT-Calculation was displayed in "negative" in the ledger. For all the clients that LineTax is enabled

The LineTax amount was displayed in negative value but the summaries are displayed correctly Only the bookings coming from the workflow were displayed in negative

[ledger123]

Hi Maria,

Very surprisingly, I cannot reproduce this error on setup. Can you test this here:

https://app.ledger123.com/rma user: demo@ledger28 pass: demo

I have enabled the line tax.

Or we can have a quick call and do it together on shared screen.

Regards

[MariaHashimi]

Hi @ledger123,

We have tested this once again and noticed that the values are still overwriting the modified values that are coming from docca. We had the case with the attached XML. rma-executor.log

We can also organize a quick meeting to show you this issue

[ledger123]

Hi @MariaHashimi ,

The original issue we had was resolved and I had verified it on my server.

Can you please reproduce this new issue on our testing server? I do not have docca setup and cannot reproduce it and also the log will not help.

If everything is working perfectly in sql-ledger then problem is probably at docca end.

And if the issue cannot be reproduced on our test server or cannot be explained in some simple way than we shall discuss it in our meeting with screen sharing if needed.

Regards

[ledger123]

Hi @MariaHashimi ,

I have switched the branch. Can you please on our demo server and confirm all is ok now?

Regards

[MariaHashimi]

HI @ledger123 , Successfully tested on your demo environment - will push this to our INT and close the issue. Thanks a lot for the fix :)