ledger123 / runmyaccounts

SQL-Ledger Customizations by Run My Accounts
GNU General Public License v2.0
16 stars 9 forks source link

[IBP-154] - Batch email invoices - Filter "Not sent" is not working #418

Closed MariaHashimi closed 10 months ago

MariaHashimi commented 12 months ago

We have since a moment an issue where the filter "not sent" is not working in the batch e-mail invoices (https://infoniqa.atlassian.net/browse/IBP-154).

Sebastian told us this issue was fixed wht the following: https://github.com/ledger123/runmyaccounts/commits/master

We have merged this commit to master, but the support informs us that they still have this issue on PROD clients (Example: Invoice “21.11.2023” on client musterfirma)

The support has tested it on your environment as well and the is issue still appears (please see video that I will send you by e-mail)

ledger123 commented 11 months ago

Hi Maria,

Good morning.

I just went through the code and discovered that you can only batch email AR invoices and not AR transactions. The video you have sent is showing an AR transaction and not an invoice.

Here is code segment in SL/BP.pm which limits the list to invoices only:

image

Kindly check and confirm that invoices are correctly shown.

Regards

MariaHashimi commented 11 months ago

Hi @ledger123, Philip from the support tested it with AR invoices and they don’t work either. Video attached.

Uploading Invoices Batch Email.mp4…

MariaHashimi commented 10 months ago

Hi @ledger123, This ticket was successfully tested by our support-team on INT - Closing the ticket :)