search

ledger123 / runmyaccounts

SQL-Ledger Customizations by Run My Accounts
GNU General Public License v2.0
16 stars 9 forks source link

Booking changes values #541

Open barworobiec opened 3 months ago

barworobiec commented 3 months ago

When you try to book an existing AP booking some positive numbers turn to negative numbers and the booking becomes a direct debit booking. As far as i can see this is only “visual“ in the booking itself and in the database and the journal the numbers are correct. image once I will click button 'Post' the value is changed to '-' image

ledger123 commented 3 months ago

Surprising. I test this on my server and fix.

Regards

barworobiec commented 3 months ago

Managed to reproduce it on your environment. The AR ref number is: Test_BW0708

Here is the screenshot: image and the value goes to negatvie when I will go into the details: image

As I noticed, you have to mark the checkbox of the tax then click update and then post, once you will open the details the value is negative.

ledger123 commented 3 months ago

Hi @barworobiec , this is fixed and code pushed to github in the respective branch.

Also our test server is on this branch and you can test on our test server as well as on your own server.

Regards

barworobiec commented 2 months ago

HI @ledger123 we have a problem with bookings which exist before the fix (ones with negative value already) So now when we want to fix them and after remove of '-' prefix, and then click Update - (value is OK - positive) > Book then the value is not changed and still is negative. You can check on your environment on AP booking ref: Test_BW0708.

Steps:

  1. Open AP booking ref: Test_BW0708 image
  2. Remove '-' prefix and click 'Update' image
  3. Value is OK, but after clicking the 'Post', the value in journal is not changed still '-150,00' image
ledger123 commented 2 months ago

Hi @barworobiec ,

I tried with things with code changes and then I also figured out the following step to correct old bookings.

  1. Confirm the nature of transaction (Regular transaction or debit/credit note)
  2. Open the transaction and post it without removing the sign.
  3. Open the transaction again and if it is still not corrected, add the '-' sign (if not already there) or remove the '-' sign if already there and post again.

I was able to correct the Test_BW0708 this way. So you can try it on my server.

If you are unable to do it this way, let me know and I shall create a screen cast to do it.

Regards

DevAtRMA commented 2 months ago

Hi @ledger123

I was able to fix the bookings the way you described, thanks.

Regards

barworobiec commented 2 months ago

@ledger123 will be there a code fix, or we should apply workaround?

ledger123 commented 2 months ago

No further code changes. Solutions without code fixes are always better. Code fixes can introduce more issues so lets not do in this case.

Thanks