ledgerloops / ledgerloops.com

Contents of https://ledgerloops.com
https://ledgerloops.com
9 stars 0 forks source link

Too many treeTokens generated #47

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

When running node src/index.js in current master (after fix-rewires branch was merged), you see various different treeTokens and various different nodes decide to pubkey-announce. Not very efficient; maybe the condition for initiatiing DFS after DDCD can be made stricter, so only one of the nodes starts a DFS-tree. Then, also only the owner of that tree would start pubkey-announce.

The way it is now wastes resources on DFS messages, and also the number of trees you see suddenly appear on a peerPair is an indication by which you can probably guess the loop length too easily.

michielbdejong commented 7 years ago

i think this is fixed, in any case, in a loop with multiple initiators (which is not necessarily a bad thing, it keeps transactions small), the ones that are over budget will get rejected.