Giraffe code readability

[michielbdejong]

There are many things going on in the Node and Giraffe code:

• Node handles meeting and message dispatching
• Giraffe handles probe creation and forwarding
• It also handles tracing

Maybe I can make it nicer if I use some sub objects:

• FriendsManager
  • keep track of friends
  • sending, logging and dispatching message from/to other nodes
  • trigger new-friend event
• ProbesManager
  • listen for new-friend event
  • create/forward Probes
  • trigger probe-loopback events (root, internal, leaf)
• TracesManager
  • listen for probe-loopback events
  • create/forward Traces
  • trigger trace-loopback events
• LoopsManager
  • listen for trace-loopback events
  • keep track of loops

[michielbdejong]

The refactor is going quite well so far, with Giraffe as a base class. One main thing to work out is how to update the message forwarder. I think it makes sense if the tests instantiate a NetworkSimulator, and adds NetworkNodes with names to it.

A NetworkNode has a process method, and it emits message(to, msgStr) events

[michielbdejong]

The TraceManager needs to read Probe info when a Trace comes in. I vaguely remember you can do this with events, but in https://nodejs.org/api/events.html I only see reference to catching an error from a listener, not to getting a return value.

I'll pass an anonymous function to the event handler. Might refactor this later if I have a better idea.