search

ledgerwatch / erigon-lib

Dependencies of Erigon project, rewritten from scratch and licensed under Apache 2.0
Apache License 2.0
59 stars 85 forks source link

Parse EIP-4844 transactions wrapped with blobs #1037

Closed yperbasis closed 1 year ago

yperbasis commented 1 year ago

Continuation of PR #1034

roberto-bayardo commented 1 year ago

Perhaps this is going to be in a future CL but I don't see yet any checks that verify the blob wrapper validity (e.g. num-blobs == num-blob-hashes == num-commitments == num-proofs, and that the proofs match)

Otherwise LGTM

yperbasis commented 1 year ago

Perhaps this is going to be in a future CL but I don't see yet any checks that verify the blob wrapper validity (e.g. num-blobs == num-blob-hashes == num-commitments == num-proofs, and that the proofs match)

That's right, we need to do the checks in a subsequent PR.