ledgerwatch / erigon-lib

Dependencies of Erigon project, rewritten from scratch and licensed under Apache 2.0
Apache License 2.0
59 stars 93 forks source link

[WIP] compress/decompress.go::Match modified #1042

Closed racytech closed 1 year ago

AskAlexSharov commented 1 year ago

@racytech just merged method DisableFsync for tests

racytech commented 1 year ago

When you say requestKey which is after latest key in file does it mean that I have to open reader and a writer at the same time or what does it mean? and for suffixes do I have to read entire word from file and compare it to given suffix?

AskAlexSharov commented 1 year ago

I mean:

About suffixes: i didn’t mean any specific functionality (no new features). just “negative test-case”: search for “non existing key” and “search for existing suffix” may trigger different bugs - especially in method which does “partial key comparison”.

AskAlexSharov commented 1 year ago

FYI: i created similar feature request - https://github.com/ledgerwatch/erigon-lib/issues/1053

racytech commented 1 year ago

Will create a new PR, since this one isn't right