search

ledgerwatch / erigon

Ethereum implementation on the efficiency frontier
GNU Lesser General Public License v3.0
3.03k stars 1.04k forks source link

use t.TempDir() in tests #10774

Closed AskAlexSharov closed 1 week ago

AskAlexSharov commented 1 week ago

for https://github.com/ledgerwatch/erigon/actions/runs/9517264736/job/26259577369?pr=10753#step:11:542

--- FAIL: TestBlockhash (0.01s)
    runtime_test.go:397: expected no error, got open /tmp/execute-vm/snapshots/salt-state.txt: no such file or directory
FAIL

don't use /tmp / os.TempDir() - because tests are run in-parallel.

AskAlexSharov commented 1 week ago

All is ok but what is the motivation of that?

https://github.com/ledgerwatch/erigon/pull/10774#issue-2356289788