search

ledoge / novideo_srgb

Calibrate monitors to sRGB or other color spaces on NVIDIA GPUs, based on EDID data or ICC profiles
GNU General Public License v3.0
1.03k stars 39 forks source link

Clamping carries over to HDR mode #4

Closed valentyn-l closed 2 years ago

valentyn-l commented 3 years ago

The sRGB clamping of DCI-P3 colors carries over when enabling HDR, be it on the desktop or playing HDR games, which unintendedly reduces color depth and saturation.

ledoge commented 3 years ago

Can't do anything about that, unfortunately. Don't think the API lets you specify whether to apply it to SDR only or also to HDR. Alternatively, it might be possible to periodically check if HDR if active on a monitor and toggle the clamp accordingly. Not sure how much effort that would be to implement.

valentyn-l commented 3 years ago

Ah, I understand. Thank you! :)

I just wanted to also say that enabling HDR actually provides the correct colour space for non-HDR content on a DCI-P3 compliant display, but its current implementation in Windows (both 10 and 11) is buggy and unreliable. Sometimes when exiting HDR application such as games, the image becomes over-brightened and oversaturated for no reason, and on the flip-side when exiting SDR applications into an HDR environment, the image becomes too dark.

I don't know if this is an Nvidia driver or Windows issue as I haven't had the chance to test with an AMD GPU, but I sure hope that it gets fixed some day.

beefcat666 commented 2 years ago

Thought I would chime in and voice my support for implementing a fix for this, even if it is a bit hacky.

Windows has an event you can listen for that fires off whenever there is a change to the display settings. I assume that includes switching between SDR and HDR.

My monitor forcibly enables its variable backlighting feature when in HDR mode, so I prefer to only use it when viewing actual HDR content. This results in me switching fairly frequently.

ledoge commented 2 years ago

Should be fixed now with the v3.2 release.