ledoge / novideo_srgb

Calibrate monitors to sRGB or other color spaces on NVIDIA GPUs, based on EDID data or ICC profiles
GNU General Public License v3.0
1.04k stars 40 forks source link

Linux VS Windows Clamp Results difference issue #63

Open MaximOstapenko opened 1 year ago

MaximOstapenko commented 1 year ago

Hi, first of all I want to thank you for your hard work. I used your method for the Linux srgb clamp (used your Program.cs to get the values based on the EDID from my icc profile (it's the same in windows novideo) of the monitor), but I also have a Windows with novideo srgb. Although it is not a perfect comparison because the light behind the monitor is on, to compare the results I used an iPhone with an app that allows me to lock the shutter speed, iso, white balance and took a raw photo. I also used the same djv photo viewer app and the results are different, especially in the reds. Unfortunately I don't have a colorimeter right now, but on linux the colors are above the srgb zone because on Windows they are almost identical to srgb as measured by the colorimeter. I will make comparisons in computer graphics VFX programs and maybe the result will be different there (UPD: no it's the same) image image image image image image

DitherMan420 commented 1 year ago

I don't think the author checks this github anymore :-/. I'm not even sure if this software is still supported? Looks like the author hasn't answered questions here in ages.....

MaximOstapenko commented 1 year ago

I don't think the author checks this github anymore :-/. I'm not even sure if this software is still supported? Looks like the author hasn't answered questions here in ages.....

For Windows it works perfectly. For linux, the only solution is to just buy a monitor with built-in sRGB mode. But if your work does not require high accuracy, it's okay, better than nothing.

DitherMan420 commented 1 year ago

I don't think the author checks this github anymore :-/. I'm not even sure if this software is still supported? Looks like the author hasn't answered questions here in ages.....

For Windows it works perfectly. For linux, the only solution is to just buy a monitor with built-in sRGB mode. But if your work does not require high accuracy, it's okay, better than nothing.

Good to know thanks. yea unfortunately I am just not sure if this software is abandoned or if the developer checks this page?

24fpsDaVinci commented 1 year ago

how are you clamping in linux? are you using xorg gnome color profiles?

MaximOstapenko commented 1 year ago

Sorry, but I forgot and steel need to recover my brain. I love linux, but right now I'm on windows. Maybe I'll try it later. Also I would use a monitor that have built-in sRGB mode.

rkurbatov commented 1 year ago

Ther is a C# program provided here - https://github.com/ledoge/novideo_srgb/issues/2#issuecomment-921688742

It takes RGB primaries and produces set of coefficients that can be used in xrandr like xrandr --output DP-2 --set CscMatrix 55648,10492,-604,0,2688,61367,1479,0,758,3087,61689,0

There can be difference if you use different profiles for your Linux/Windows box. Or different driver settings regarding to saturation and gamma, whatever.

ziomek64 commented 5 months ago

Is there anything for wayland?

24fpsDaVinci commented 5 months ago

Is there anything for wayland?

kde wayland supports gamut clamping to srgb since 6.0

ziomek64 commented 5 months ago

Is there anything for wayland?

kde wayland supports gamut clamping to srgb since 6.0

Where? In display settings I've set my icc profile that I clamped to srgb and it works globally, but I don't see a clamp option to just one click it.

24fpsDaVinci commented 5 months ago

It should be automatic when you select an ICC profile. No need to pre-clamp the profile in Kwin. https://invent.kde.org/plasma/kwin/-/merge_requests/4471

ziomek64 commented 5 months ago

It should be automatic when you select an ICC profile. No need to pre-clamp the profile in Kwin. https://invent.kde.org/plasma/kwin/-/merge_requests/4471

How to create unclamped clean icc profile? Program I used for creating a profile (raw therapee) has icc profile creator from edid data and I have to select some gamut so I took sRGB.

24fpsDaVinci commented 5 months ago

there should be an auto generated icc profile in system settings. ~/.local/share/icc

ziomek64 commented 5 months ago

there should be an auto generated icc profile in system settings. ~/.local/share/icc

I don't have icc folder in local share

24fpsDaVinci commented 5 months ago

in raw therapee i think you can enter your own Primary values to create a profile instead of using preset idealized profiles.

you can use Edid-decode to get the values.

I dont have raw therapee installed.

If you have GNOME desktop installed it will also auto generate profiles. and you will see it under in the icc folder

ziomek64 commented 5 months ago

in raw therapee i think you can enter your own Primary values to create a profile instead of using preset idealized profiles.

you can use Edid-decode to get the values.

I dont have raw therapee installed.

If you have GNOME desktop installed it will also auto generate profiles. and you will see it under in the icc folder

That's what I did. Let me show yow how it looks. I set my own edid data, then for tone response I gotta select some gamut sRGB, BT709, standard2.2 or 1.8, or do custom obraz

24fpsDaVinci commented 5 months ago

for TRC tone response curve, you can set one closest to your monitor OSD setting, probably gamma 2.2 or sRGB. Tone response is gamma, it wont affect colors.

ziomek64 commented 5 months ago

for TRC tone response curve, you can set one closest to your monitor OSD setting, probably gamma 2.2 or sRGB. Tone response is gamma, it wont affect colors.

So kde just clamps everything no matter what to sRGB? Interesting. But yeah I've selected that sRGB tone response curve created icc profile and put it in KDE. But someone told me in 6.1 plasma there seems to be menu checkbox to just clamp. In display settings screen. That will be interesting.

ziomek64 commented 5 months ago

This is from 6.1 beta. There just seems to be option to use built-in and it probably will clamp. Can't wait obraz

24fpsDaVinci commented 5 months ago

Ok, it looks like it can auto generate profiles then. Nice