Error Code 104 when applying clamping.

ledoge / novideo_srgb

Calibrate monitors to sRGB or other color spaces on NVIDIA GPUs, based on EDID data or ICC profiles

GNU General Public License v3.0

1.04k stars 40 forks source link

Error Code 104 when applying clamping. #66

Open Waltonnn opened 1 year ago

Waltonnn commented 1 year ago

I was following this guide to setup HDR on my Samsung Odyssey Neo G9 - https://www.reddit.com/r/ultrawidemasterrace/comments/11rg1o4/odyssey_neo_g9_hdr_settings_windowsgames/

After applying Clamped with SDR enabled - Every time I load HDR I get the attached error and the programme won't stay open.

Silver812 commented 1 year ago

I have this issue too on my G8.

antonp92 commented 1 year ago

I'm experiencing the same issue on my AW3423DW, which NVIDIA Drivers are you using?

Just tested this on 531.68 and I'm not seeing this error, the clamp is disabled when toggling HDR. As soon as I switch to the latest drivers 531.79 I receive the Error Code 104 and the clamp is applied in HDR as well which causes washed out colors.

Silver812 commented 1 year ago

I am in 531.79, does this mean that I should roll back to .68?

Or maybe this could be fixed in some way without changing the driver?

Waltonnn commented 1 year ago

I am using 531.79, going to try to rollback to .68, hopefully the owner hasn't abandoned this project as that is not a long term fix.

Waltonnn commented 1 year ago

I rolled back and I am no longer getting the error. Hopefully we can see a fix pushed to the latest drivers.

jxlarrea commented 1 year ago

+1, also seeing this behavior.

weili-jiang commented 1 year ago

@antonp92 I'm on 536.23, it doesn't seem to actually clamp in HDR mode, at least not that I can tell. To test, I have forced the clamped gamma to something crazy and in HDR mode it looks like it always does (not crazy gamma). I guess if I could be bothered, I could get out the Spyder to check...

weili-jiang commented 1 year ago

I have created a build on my fork to suppress the error: https://github.com/weili-jiang/novideo_srgb/releases/tag/suppress-disable-error

It works well enough for my purposes - SDR clamped for photo/video editing, HDR for gaming. I can't tell the difference when gaming in HDR so it's good enough for me. Since this is all using undocumented APIs, it may all break some day...

DitherMan420 commented 1 year ago

I started getting this issue as soon as I updated to the newest Nvidia drivers...

DitherMan420 commented 1 year ago

I have created a build on my fork to suppress the error: https://github.com/weili-jiang/novideo_srgb/releases/tag/suppress-disable-error

It works well enough for my purposes - SDR clamped for photo/video editing, HDR for gaming. I can't tell the difference when gaming in HDR so it's good enough for me. Since this is all using undocumented APIs, it may all break some day...

This will supress the error, sure, but the issue is that the clamp is still applied even in HDR. There is no more "auto unclamp when Hdr" functionality. This 100% started with new nvidia drivers :-/.