leduycuong86 / openbmap

Automatically exported from code.google.com/p/openbmap
Other
0 stars 0 forks source link

Uploaded files are not preserved on 0.8.8 #78

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Log some data.
2. Make sure "Keep uploaded files" is selected in options.
3. Upload the log.
4. Examine the data folder.

What is the expected output? What do you see instead?
I would expect the XML files that got uploaded to be present in the data folder 
(org.openbmap on the SD card). Instead, no files are present.

What version of the product are you using? On what operating system?
0.8.8 (e2a52fc-dirty) from F-Droid, on Cyanogenmod 11.0 M11

Please provide any additional information below.
I upgraded from 0.8.4 (last F-Droid release before 0.8.8) and things worked 
before the upgrade. The bug must have been introduced somewhere in between.

Original issue reported on code.google.com by mich...@vonglasow.com on 17 Jun 2015 at 7:00

GoogleCodeExporter commented 9 years ago
Update: after digging through the code, I found that the path has changed. 
Indeed, I find my logs in /Android/data/org.openbmap. However, all files now 
have filenames like "filesV1_log20150617133700-wifi.xml". Could that be a 
forgotten path separator somewhere?

More important, as the file name is part of the spec: will these files still 
import successfully?

Original comment by mich...@vonglasow.com on 17 Jun 2015 at 7:12

GoogleCodeExporter commented 9 years ago
You're faster than I can reply :-)

Agilob raised the important point, that it makes sense to store data under 
Android/data to comply with Android standards 
(https://github.com/wish7code/org.openbmap.unifiedNlpProvider/issues/10). So 
this was changed with 0.8.8
This also guarantees, that the folder is deleted once Radiobeacon is installed.

Thanks for the hint on the file names, this is now corrected with 
r49fa03e7be40..
The good news: Just checked the uploads, files arrived fine nevertheless..
(last of your uploads 2015-06-17 20:54:18)

Original comment by wish7code on 17 Jun 2015 at 7:43

GoogleCodeExporter commented 9 years ago
Well... not sure if it's really desirable to nuke all data when uninstalling 
the app... but that's a fault in the design of Android, not the app.

There is one issue that remains: the media scanner doesn't get triggered (still 
on 0.8.8 e2a52fc-dirty). When I export the files and browse the folder with 
MTP, no new logs are there. When I do the same with the CM file manager, I see 
the whole list of files. You might want to try reproducing this on the latest 
build – maybe it has to do with the missing path separator and the media 
scanner is scanning the files subdir when the files are placed in its parent. 
Didn't check the code...

Original comment by mich...@vonglasow.com on 18 Jun 2015 at 6:34