search

lee-dohm / file-type-icons

Atom package that changes the icon for files in the Tree View and Tabs to reflect the file's type
https://atom.io/packages/file-type-icons
Other
28 stars 19 forks source link

[.git] Update `github` icon to `repo` icon #1

Closed Nicolab closed 10 years ago

Nicolab commented 10 years ago

Icon github is inappropriate for a .git repository.

That gives the possibility of an evolution, if in the future we look in .git and the remote repository is GitHub, it would be interesting to put the icon GitHub instead of generic repo icon. It would be great feature! (TODO :smiley:)

If the generic icon repo does not please you, would it be possible to consider another generic icon? Example http://octicons.github.com/icon/git-branch/ that resembles to the official logo of GIT.

Thanks for this useful package makes my Atom editor most friendlier ;)

lee-dohm commented 10 years ago

I'm a little torn. I like the GitHub icon for the .git directory. On the other hand, it doesn't really matter to me because the vast majority of the time I hide the .git directory. Let me think about it for a little bit.

davelandry commented 10 years ago

Interesting point. I can see both sides, but I think I would also prefer the repo icon.

lee-dohm commented 10 years ago

Thanks for the contribution!