search

lee-dohm / file-type-icons

Atom package that changes the icon for files in the Tree View and Tabs to reflect the file's type
https://atom.io/packages/file-type-icons
Other
28 stars 19 forks source link

JS icon alignment issue #12

Closed jbergstroem closed 10 years ago

jbergstroem commented 10 years ago

(using 0.4.3)

It seems like the new js icon is throwing alignment a bit off in the menu bar. See attached screenshots with package enabled/disabled screen shot 2014-08-19 at 10 42 13 am screen shot 2014-08-19 at 10 42 04 am

Also, my .2c about the updated js icon is that the text-only nature makes it somewhat ambiguous. perhaps use the one that nodejs provides (octagon js)?

lee-dohm commented 10 years ago

Thanks for reporting this!

The change I made in c92233c0cf74458945e423065cc0d4dc708c2211 to fix #10 is what is making things not align correctly in that specific instance. I'll see what I can do about it.

lee-dohm commented 10 years ago

Note to self: this isn't just the JS icon, it is all of the DevIcons provided icons.

lee-dohm commented 10 years ago

I do like the Node.js icon, though some might object to its use as a general JavaScript icon because of its specific association with Node. The simple fact of the matter is that there is no good logo or icon for JavaScript :laughing:

jbergstroem commented 10 years ago

I agree. I'd also argue that the nodejs-"specific" icon is slightly suffering from sub-pixel rendering issues (at least the one from that same package). Gotta hand it to github and their octicons. The effort they've put into it really shows.

lee-dohm commented 10 years ago

I thought that was a great article. It was also really helpful in understanding how to use icon fonts better in this package.

jbergstroem commented 10 years ago

Still seeing this with the js icon screen shot 2014-09-12 at 3 20 46 pm

edit: ah shit, never mind. No release yet.