search

lee-dohm / file-type-icons

Atom package that changes the icon for files in the Tree View and Tabs to reflect the file's type
https://atom.io/packages/file-type-icons
Other
28 stars 19 forks source link

Doesn't work with Gulpfile.js #17

Closed MoOx closed 10 years ago

MoOx commented 10 years ago

Gulpfile.js doesn't have the icon. gulpfile.js have it.

Both are working for gulp.

Any idea ?

lee-dohm commented 10 years ago

Yes, it appears that attribute matching (the method used to add the icon) is case-sensitive only. If Gulpfile.js is a common alternative (or the primary usage), then I can easily add support for that. If I need to support any possible casing (such as gUlPfIlE.JS) then that is a bigger problem.

Will just supporting [Gg]ulpfile.js be sufficient do you think?

MoOx commented 10 years ago

I think so :)

lee-dohm commented 10 years ago

Ok, I'll take a look later today.

On Oct 13, 2014, at 8:59 AM, Maxime Thirouin notifications@github.com wrote:

I think so :)

— Reply to this email directly or view it on GitHub.

davelandry commented 10 years ago

Maybe also consider supporting [Gg]ulpfile.coffee files?