lee-dohm / file-type-icons

Atom package that changes the icon for files in the Tree View and Tabs to reflect the file's type
https://atom.io/packages/file-type-icons
Other
28 stars 19 forks source link

Javascript icon is a little funky #4

Closed taylorlapeyre closed 10 years ago

taylorlapeyre commented 10 years ago

Keep in mind that icons in tabs are bolded by default:

screenshot 2014-06-23 16 12 03

Perhaps a clearer icon could solve this?

lee-dohm commented 10 years ago

Thanks for reporting this.

If anyone has a suggestion for where I can find a better icon for JavaScript files, let me know. I've looked around and haven't been able to find anything yet.

I'll see if I can fix the font weight in tabs too.

jbergstroem commented 10 years ago

Not really sure it's about bold, rather the fact that it might not be subpixel-optimised like most of the github stuff is (guess I'm just stating the obvious here).

lee-dohm commented 10 years ago

Actually, the latest version of the package should make the icon clearer. None of the icon fonts is subpixel-optimized, so I put the right font smoothing setting on the icons and things are much clearer.

taylorlapeyre commented 10 years ago

Thanks @lee-dohm!

jbergstroem commented 10 years ago

Its a noticeable difference on things like the globe, but the javascript icon is still pretty sub-par for me. All I'm saying is that the hunt for a better icon is still on :)

lee-dohm commented 10 years ago

I figured that would be the case, so I left the bug open :grinning: