Closed oliviertassinari closed 1 year ago
These are promises, we need to use await to be able to catch the errors. For example, in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153 the job failed but is marked as successful 🙈.
await
(The job failed because MUI didn't set the right permissions, we use "Default access restricted" in https://docs.github.com/en/actions/security-guides/automatic-token-authentication).
Context: https://github.com/mui/mui-x/pull/6658
No review, closing
oliviertassinari
commented
1 year ago oliviertassinari
commented
1 year ago
These are promises, we need to use
awaitto be able to catch the errors. For example, in https://github.com/mui/mui-x/actions/runs/3350385087/jobs/5551157153 the job failed but is marked as successful 🙈.(The job failed because MUI didn't set the right permissions, we use "Default access restricted" in https://docs.github.com/en/actions/security-guides/automatic-token-authentication).
Context: https://github.com/mui/mui-x/pull/6658