lee-soft / ViStart

Open source start menu replacement for Windows systems
GNU Affero General Public License v3.0
50 stars 8 forks source link

ViStart v8.1.5255 #5

Closed GeorgeK1ng closed 1 year ago

GeorgeK1ng commented 1 year ago

Known bugs: 1) When using Start search "Files" string can't be translated right now, I can't find correct place to replace this string with Language related string saved as "StrFiles" in Language.xml 2) NavigationPane font color is always white, this needs to be solved and enable some kind of Font Color option into layout.xml - this is already here, nothing to investigate 3) When using Right click on "Run..." StartMenu keeps open and Run dialogbox is not on correct place

GeorgeK1ng commented 1 year ago

Here you can see translations improvements

ViStart_Tr01 ViStart_Tr02 ViStart_Tr03 ViStart_Tr04 ViStart_Tr05 ViStart_Tr06

Here is last remaining "Files" word that needs to be mapped to "StrFiles". Hope you can find cause of this "non-translatable" item ViStart_Tr07

And here is demostrated needs of colorized font in NavigationPane. As you can see, it's really badly visible white font on Blue background. I would like to see option in layout.xml. But I was unable to find correct place where I can specify font color for Navigation pane items ViStart_Tr_F1

P.S. Code for context menu is not clear at all, but works

lee-soft commented 1 year ago

I think the "Files" is actually a bitmap in the "Vistart.RES". I was meaning to change this some day to be actual text. You might need to open ViStart.RES with ResHacker to change it for yourself

Skinning with ViStart 8.pdf Maybe the ViFont section will help you with change the colours. I am not sure it can be changed from memory. I think it's hard coded.

I will have a look at these changes over the weekend. Thanks for contributing

GeorgeK1ng commented 1 year ago

I have uploaded Brazilian.xml again right now

GeorgeK1ng commented 1 year ago

I have reuploaded whole ViStart Source tree grabbed from XP machine.

ViStart.RES doesn't contain any BMP / PNG with "Files" caption for Start Search. I have currently no idea where is hardcoded "Files" string. Hope you can find it out to make 100% strings translatable

So still these 2 bugs are there 1) "Files" string is not loaded from translation file 2) Start menu keeps open and Run dialog box is not placed correctly when right click on Run... and use context menu Run...

EDIT: Seems like GitHub can't show correctly uploaded files from some reason. Better to download repository and compare files using Beyond Compare for example. My attempt touch minimum code to achieve mentioned changelog

EDIT2: Can you upload somewhere (skins folder will be the best) any other themes that you have for ViStart 8.1 please?

lee-soft commented 1 year ago

We can safely ignore whitespace changes, the PR looks bigger than it actually is. On GitHub there is a feature to hide whitespace changes. So do not worry about it

GeorgeK1ng commented 1 year ago

Language files seems to be broken as I used your original ones with only adding new elements inside. I have rebuilded right now all of them except Korean as I can't do this one on my XP machine.

fediaFedia commented 1 year ago

Glad to see someone is working on ViStart!

Just an FYI, at some point the Windows 11 Compatibility got broken :( I used built 5257 here: https://www.deviantart.com/fediafedia/art/Longhorn-2022-ViStart-11-WIP-905330208

GeorgeK1ng commented 1 year ago

Glad to see someone is working on ViStart!

Just an FYI, at some point the Windows 11 Compatibility got broken :( I used built 5257 here: https://www.deviantart.com/fediafedia/art/Longhorn-2022-ViStart-11-WIP-905330208

Nice to see you here! Maybe you can help me with adapting current themes to ViStart. I have collected various of them on Deviantart, including yours. I will send you more info to e-mail from your profile description. With your help can be ViStart Themes pefrect!

About Windows 11 compatibility, maybe @lee-soft can solve it. Currently This build 5255 is tested on my side only on XP host. In future I will test it under Vista / 7 too to see what else needs to be modded according to full translation support.

GeorgeK1ng commented 1 year ago

Reuploaded all languages again, Added incomplete Russian translation from another Fork with all needed strings for 8.1.5255