leebaird / discover

Custom bash scripts used to automate various penetration testing tasks including recon, scanning, enumeration, and malicious payload creation using Metasploit. For use with Kali Linux.
MIT License
3.41k stars 819 forks source link

Feature Improvement: Files > display URLs as links #117

Closed arthurakay closed 5 years ago

arthurakay commented 6 years ago

As a user, it would be great if the files listed in things like the "Files > PDF" pane were clickable so I didn't have to copy/paste them (assuming I wanted to view them).

arthurakay commented 5 years ago

For what it's worth, this could be as easy as altering goofile.py at lines 78-79 to be:

        for x in result:
            print "<a href='{0}'>{0}</a>".format(x)

However, I'm noticing that the code parsing Google's search results doesn't always return you a usable link. Sometimes they're formatted as http://domain.com/path/to/file.pdf, but other times they look like domain.com/.../file.pdf and other times just file.pdf.

I'd have to dig into why goofile.py is reporting the links like that in the first place.

I see that this file is modified from whatever original version existed on Google Code years ago. I'd be curious how open you are to having it rewritten, though maybe that's too much work just to have these links be clickable.

arthurakay commented 5 years ago

Actually, it looks like goofile.py isn't correctly parsing some of the links -- the ones with the ... and other bad formatting appear to be duplicates, just mangled.

Maybe rewriting this file wouldn't be a bad idea after all.