Closed joacole closed 5 years ago
Hi joacole, thanks for the kind words, thanks for the suggestion I will look at getting that fixed or if you would like you can create a pull request if you would like to contribute?
Get Outlook for Androidhttps://aka.ms/ghei36
From: joacole notifications@github.com Sent: Monday, December 24, 2018 6:09:25 PM To: leebaird/discover Cc: Subscribed Subject: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Hi Lee-
Discover is a darned useful tool. Thank you for all of your hard work and effort to bring it to the community.
This is a "works as intended, but maybe a more elegant solution can be found" question. In line 1093 of discover.sh, the script attempts to find and delete all empty files starting from "/". The effect of this is that after Whatweb runs in an active domain recon, a bunch of "rm" permission errors are thrown because the command is trying to remove items in directories like /proc and /dev.
Would it be just as useful to have that "find" and "rm" line operate on $home/data/$domain only or is there other cleanup that needs to be done outside of that directory? I apologize if this has already been addressed elsewhere, but I couldn't find reference to it in the issues log.
Thanks so much!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/125, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADddQm5mSn9PelwiDpVhzn1LoYYngG4Dks5u8RhVgaJpZM4Zgm9b.
Sure thing! I’ll do the pull request now. :-)
Merry Christmas!
From: J.Townsend notifications@github.com Sent: Monday, December 24, 2018 1:39 PM To: leebaird/discover discover@noreply.github.com Cc: Joshua A. Cole joshua.cole@assurainc.com; Author author@noreply.github.com Subject: Re: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Hi joacole, thanks for the kind words, thanks for the suggestion I will look at getting that fixed or if you would like you can create a pull request if you would like to contribute?
Get Outlook for Androidhttps://aka.ms/ghei36
From: joacole notifications@github.com<mailto:notifications@github.com> Sent: Monday, December 24, 2018 6:09:25 PM To: leebaird/discover Cc: Subscribed Subject: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Hi Lee-
Discover is a darned useful tool. Thank you for all of your hard work and effort to bring it to the community.
This is a "works as intended, but maybe a more elegant solution can be found" question. In line 1093 of discover.sh, the script attempts to find and delete all empty files starting from "/". The effect of this is that after Whatweb runs in an active domain recon, a bunch of "rm" permission errors are thrown because the command is trying to remove items in directories like /proc and /dev.
Would it be just as useful to have that "find" and "rm" line operate on $home/data/$domain only or is there other cleanup that needs to be done outside of that directory? I apologize if this has already been addressed elsewhere, but I couldn't find reference to it in the issues log.
Thanks so much!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/125, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADddQm5mSn9PelwiDpVhzn1LoYYngG4Dks5u8RhVgaJpZM4Zgm9b.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleebaird%2Fdiscover%2Fissues%2F125%23issuecomment-449762437&data=02%7C01%7Cjoshua.cole%40assurainc.com%7Ce2e1e146d3fc42a2f0fe08d669cf1b05%7C7092249a50c5488fbd2574ca3b2af5ea%7C0%7C0%7C636812735561847765&sdata=p8AQ5wCQHOXGcU7G%2BjHODtQQtaiwExNasKx7fdSM7v8%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAcQ2eeFuonm6oACS0D0aU8aziwsIkYOlks5u8R9SgaJpZM4Zgm9b&data=02%7C01%7Cjoshua.cole%40assurainc.com%7Ce2e1e146d3fc42a2f0fe08d669cf1b05%7C7092249a50c5488fbd2574ca3b2af5ea%7C0%7C0%7C636812735561857770&sdata=5BLW2U5Wqziv4Gdbka13hbrIzlXOPLy7LyR0DjMB0Hg%3D&reserved=0.
Assura is certified as a Women's Business Enterprise (WBE) by the Women's Business Enterprise Council (WBENC), as an Economically Disadvantaged Woman Owned Small Business (EDWOSB) by the U.S. Small Business Administration; and Small Woman and Minority (SWaM) in the Commonwealth of Virginia.
This message is intended only for the individual named as the intended recipient. If you are not the intended recipient you should not disseminate, distribute or copy this email. Please notify the sender immediately if you have received this email by mistake and delete it. Email transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain malware such as viruses. The sender therefore does not accept liability for any malicious code, errors, or omissions in the contents of this message which may arise as a result of this transmission.
If you have any questions, please contact Assura, Inc. at 7814 Carousel Lane, Suite 202 | Richmond, VA 23294 USA | Phone: +1.804.672.8714 | www.assurainc.com
Merry Christmas and thank you for the contribution
Get Outlook for Androidhttps://aka.ms/ghei36
From: joacole notifications@github.com Sent: Monday, December 24, 2018 6:55:02 PM To: leebaird/discover Cc: J.Townsend; Comment Subject: Re: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Sure thing! I’ll do the pull request now. :-)
Merry Christmas!
From: J.Townsend notifications@github.com Sent: Monday, December 24, 2018 1:39 PM To: leebaird/discover discover@noreply.github.com Cc: Joshua A. Cole joshua.cole@assurainc.com; Author author@noreply.github.com Subject: Re: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Hi joacole, thanks for the kind words, thanks for the suggestion I will look at getting that fixed or if you would like you can create a pull request if you would like to contribute?
Get Outlook for Androidhttps://aka.ms/ghei36
From: joacole notifications@github.com<mailto:notifications@github.com> Sent: Monday, December 24, 2018 6:09:25 PM To: leebaird/discover Cc: Subscribed Subject: [leebaird/discover] "rm" errors thrown after Whatweb executes (#125)
Hi Lee-
Discover is a darned useful tool. Thank you for all of your hard work and effort to bring it to the community.
This is a "works as intended, but maybe a more elegant solution can be found" question. In line 1093 of discover.sh, the script attempts to find and delete all empty files starting from "/". The effect of this is that after Whatweb runs in an active domain recon, a bunch of "rm" permission errors are thrown because the command is trying to remove items in directories like /proc and /dev.
Would it be just as useful to have that "find" and "rm" line operate on $home/data/$domain only or is there other cleanup that needs to be done outside of that directory? I apologize if this has already been addressed elsewhere, but I couldn't find reference to it in the issues log.
Thanks so much!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/125, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADddQm5mSn9PelwiDpVhzn1LoYYngG4Dks5u8RhVgaJpZM4Zgm9b.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fleebaird%2Fdiscover%2Fissues%2F125%23issuecomment-449762437&data=02%7C01%7Cjoshua.cole%40assurainc.com%7Ce2e1e146d3fc42a2f0fe08d669cf1b05%7C7092249a50c5488fbd2574ca3b2af5ea%7C0%7C0%7C636812735561847765&sdata=p8AQ5wCQHOXGcU7G%2BjHODtQQtaiwExNasKx7fdSM7v8%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAcQ2eeFuonm6oACS0D0aU8aziwsIkYOlks5u8R9SgaJpZM4Zgm9b&data=02%7C01%7Cjoshua.cole%40assurainc.com%7Ce2e1e146d3fc42a2f0fe08d669cf1b05%7C7092249a50c5488fbd2574ca3b2af5ea%7C0%7C0%7C636812735561857770&sdata=5BLW2U5Wqziv4Gdbka13hbrIzlXOPLy7LyR0DjMB0Hg%3D&reserved=0.
Assura is certified as a Women's Business Enterprise (WBE) by the Women's Business Enterprise Council (WBENC), as an Economically Disadvantaged Woman Owned Small Business (EDWOSB) by the U.S. Small Business Administration; and Small Woman and Minority (SWaM) in the Commonwealth of Virginia.
This message is intended only for the individual named as the intended recipient. If you are not the intended recipient you should not disseminate, distribute or copy this email. Please notify the sender immediately if you have received this email by mistake and delete it. Email transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain malware such as viruses. The sender therefore does not accept liability for any malicious code, errors, or omissions in the contents of this message which may arise as a result of this transmission.
If you have any questions, please contact Assura, Inc. at 7814 Carousel Lane, Suite 202 | Richmond, VA 23294 USA | Phone: +1.804.672.8714 | www.assurainc.com
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/125#issuecomment-449763425, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADddQj4yAzapZFCzl80hOV94XYa9URgQks5u8SMGgaJpZM4Zgm9b.
Hi Lee-
Discover is a darned useful tool. Thank you for all of your hard work and effort to bring it to the community.
This is a "works as intended, but maybe a more elegant solution can be found" question. In line 1093 of discover.sh, the script attempts to find and delete all empty files starting from "/". The effect of this is that after Whatweb runs in an active domain recon, a bunch of "rm" permission errors are thrown because the command is trying to remove items in directories like /proc and /dev.
Would it be just as useful to have that "find" and "rm" line operate on $home/data/$domain only or is there other cleanup that needs to be done outside of that directory? I apologize if this has already been addressed elsewhere, but I couldn't find reference to it in the issues log.
Thanks so much!