leebaird / discover

Custom bash scripts used to automate various penetration testing tasks including recon, scanning, enumeration, and malicious payload creation using Metasploit. For use with Kali Linux.
MIT License
3.41k stars 819 forks source link

Conflict with other files of same name #138

Closed Intek13x closed 5 years ago

Intek13x commented 5 years ago

discover.sh doesn't run if there is a file of same name in any location/directory. Other scripts in different locations works properly except for this one (/opt/discover/discover.sh)

┌─[x230@ThiccPad]─[~] └──╼ $sudo /opt/discover/discover.sh

==================================================================

Found 4 instances of Discover on your system. Refer to the following paths: /home/x230/discover.sh /home/x230/Downloads/discover.sh /opt/discover/discover.sh /usr/share/sniper/modes/discover.sh

Remove or rename all but the install path and try again. If renaming, 'discover.sh' can't be in name. Try 'discover.bu' etc.

==================================================================

Even after renaming it to discover.bu, it doesn't work properly.

ninewires commented 5 years ago

Did you run updatedb after the file rename?

On Sep 4, 2019, at 5:04 AM, Intekhab Alam notifications@github.com wrote:

discover.sh doesn't run if there is a file of same name in any location/directory. Other scripts in different locations works properly except for this one (/opt/discover/discover.sh)

┌─[x230@ThiccPad]─[~] └──╼ $sudo /opt/discover/discover.sh

==================================================================

Found 4 instances of Discover on your system. Refer to the following paths: /home/x230/discover.sh /home/x230/Downloads/discover.sh /opt/discover/discover.sh /usr/share/sniper/modes/discover.sh

Remove or rename all but the install path and try again. If renaming, 'discover.sh' can't be in name. Try 'discover.bu' etc.

==================================================================

Even after renaming it to discover.bu, it doesn't work properly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Intek13x commented 5 years ago

Did you run updatedb after the file rename?

Tried it, just one less instance of Discover found. Discover script is still not running.

ninewires commented 5 years ago

You should not be renaming Discover’s discover.sh. The files located with the home directory would be unnecessary after install. That’s said, the discover.sh used by sniper will still cause an issue. I will get this in the todo list to update the discover install location check.

On Sep 4, 2019, at 5:04 AM, Intekhab Alam notifications@github.com wrote:

discover.sh doesn't run if there is a file of same name in any location/directory. Other scripts in different locations works properly except for this one (/opt/discover/discover.sh)

┌─[x230@ThiccPad]─[~] └──╼ $sudo /opt/discover/discover.sh

==================================================================

Found 4 instances of Discover on your system. Refer to the following paths: /home/x230/discover.sh /home/x230/Downloads/discover.sh /opt/discover/discover.sh /usr/share/sniper/modes/discover.sh

Remove or rename all but the install path and try again. If renaming, 'discover.sh' can't be in name. Try 'discover.bu' etc.

==================================================================

Even after renaming it to discover.bu, it doesn't work properly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

L1ghtn1ng commented 5 years ago

Jason, is possible to not care where it gets installed?


From: Jason Ashton notifications@github.com Sent: Thursday, September 5, 2019 12:03:49 PM To: leebaird/discover discover@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [leebaird/discover] Conflict with other files of same name (#138)

You should not be renaming Discover’s discover.sh. The files located with the home directory would be unnecessary after install. That’s said, the discover.sh used by sniper will still cause an issue. I will get this in the todo list to update the discover install location check.

On Sep 4, 2019, at 5:04 AM, Intekhab Alam notifications@github.com wrote:

discover.sh doesn't run if there is a file of same name in any location/directory. Other scripts in different locations works properly except for this one (/opt/discover/discover.sh)

┌─[x230@ThiccPad]─[~] └──╼ $sudo /opt/discover/discover.sh

==================================================================

Found 4 instances of Discover on your system. Refer to the following paths: /home/x230/discover.sh /home/x230/Downloads/discover.sh /opt/discover/discover.sh /usr/share/sniper/modes/discover.sh

Remove or rename all but the install path and try again. If renaming, 'discover.sh' can't be in name. Try 'discover.bu' etc.

==================================================================

Even after renaming it to discover.bu, it doesn't work properly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/138?email_source=notifications&email_token=AA3V2QXNKZHEXRBFC6TP5I3QIDRRLA5CNFSM4ITPJDEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD56WTVQ#issuecomment-528312790, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA3V2QSA45FPIEB5HADWBXLQIDRRLANCNFSM4ITPJDEA.

Intek13x commented 5 years ago

You should not be renaming Discover’s discover.sh. The files located with the home directory would be unnecessary after install. That’s said, the discover.sh used by sniper will still cause an issue. I will get this in the todo list to update the discover install location check.

Oh i know, but would not it break other scripts?

I think it would be better to use default location of Discover(/opt/discover/discover.sh) instead of "tmpinstance" in script.

ninewires commented 5 years ago

That won’t work when you don’t run the script from the install directory.

On Sep 5, 2019, at 7:13 AM, J.Townsend notifications@github.com wrote:

Jason, is possible to not care where it gets installed?


From: Jason Ashton notifications@github.com Sent: Thursday, September 5, 2019 12:03:49 PM To: leebaird/discover discover@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [leebaird/discover] Conflict with other files of same name (#138)

You should not be renaming Discover’s discover.sh. The files located with the home directory would be unnecessary after install. That’s said, the discover.sh used by sniper will still cause an issue. I will get this in the todo list to update the discover install location check.

On Sep 4, 2019, at 5:04 AM, Intekhab Alam notifications@github.com wrote:

discover.sh doesn't run if there is a file of same name in any location/directory. Other scripts in different locations works properly except for this one (/opt/discover/discover.sh)

┌─[x230@ThiccPad]─[~] └──╼ $sudo /opt/discover/discover.sh

==================================================================

Found 4 instances of Discover on your system. Refer to the following paths: /home/x230/discover.sh /home/x230/Downloads/discover.sh /opt/discover/discover.sh /usr/share/sniper/modes/discover.sh

Remove or rename all but the install path and try again. If renaming, 'discover.sh' can't be in name. Try 'discover.bu' etc.

==================================================================

Even after renaming it to discover.bu, it doesn't work properly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/leebaird/discover/issues/138?email_source=notifications&email_token=AA3V2QXNKZHEXRBFC6TP5I3QIDRRLA5CNFSM4ITPJDEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD56WTVQ#issuecomment-528312790, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA3V2QSA45FPIEB5HADWBXLQIDRRLANCNFSM4ITPJDEA. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ninewires commented 5 years ago

That is not a default location. It may be for Kali, but is not for PTF.

On Sep 5, 2019, at 8:55 AM, Intekhab Alam notifications@github.com wrote:

You should not be renaming Discover’s discover.sh. The files located with the home directory would be unnecessary after install. That’s said, the discover.sh used by sniper will still cause an issue. I will get this in the todo list to update the discover install location check.

Oh i know, but would not it break other scripts?

I think it would be better to use default location of Discover(/opt/discover/discover.sh) instead of "tmpinstance" in script.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Intek13x commented 5 years ago

That is not a default location. It may be for Kali, but is not for PTF.

Now i get it. Thanks for helping.