search

leebyron / rollup-plugin-flow

Rollup plugin for removing Flow type annotations.
Other
80 stars 11 forks source link

Update flow-remove-types #10

Open unscriptable opened 4 years ago

unscriptable commented 4 years ago

rollup-plugin-flow fails on some new flow syntax. Specifically, it fails on explicit inexact object type syntax (ellipsis in property definitions). Updating to a more recent version of flow-remove-types fixes the issue.

Note: flow-remove-types version 2.120.1 fails on basic class syntax. Seems like that version is not ready for production, yet. Version 2.119.1 works on the updated tests and on our source code.

unscriptable commented 4 years ago

From the Travis log, it looks like flow-remove-types uses syntax that node 7.x doesn't understand.

Any thoughts on how to resolve this? We'd really love to keep using this awesome plugin. Perhaps:

  1. Update the major version in this plugin's package.json to 2.x
  2. Update the README to inform users that version 2.x no longer works with older versions of node (lower than node 8.x?)
  3. Update the Travis env to run node 8, 10, and 12.
unscriptable commented 4 years ago

Hey @leebyron. Any guidance on this issue? Thanks!

leebyron commented 4 years ago

Sorry for missing your message above. I think the plan as you outlined it makes sense. Want to include those changes in this PR?