search

leecade / react-native-swiper

The best Swiper component for React Native.
MIT License
10.4k stars 2.34k forks source link

Animated.ScrollView #674

Open SabatinoMasala opened 6 years ago

SabatinoMasala commented 6 years ago

In our app we're currently using a modified version of react-native-swiper, where we replaced ScrollView with Animated.ScrollView (here), so we can bind an Animated.Event to the onScroll handler.

Is this something we can add to the main library? Through a prop for example:

<Swiper animated={true}></Swiper>

And in the code of react-native-swiper we can conditionally render an Animated.ScrollView or a regular ScrollView.

Is this something we can add through a PR, or do you have other/better suggestions?

mbret commented 3 years ago

Just installed the library this week thinking this would be basic feature until I realized it's not wrapped with it. Ended up doing a fork as well. I will create a PR for that, it's honestly weird that this feature is missing