search

leecade / react-native-swiper

The best Swiper component for React Native.
MIT License
10.4k stars 2.34k forks source link

loadMinimalSize and loadMinimalLoader types should be declared as number and React.Node in index.d.ts #963

Open willmanio opened 5 years ago

willmanio commented 5 years ago

Which OS ?

N/A

Version

Which versions are you using:

Expected behaviour

When using react-native-swiper in a TypeScript project, I should be able to enable the loadMinimal prop and specify the loadMinimalSize as a number. I should also be able to specify loadMinimalLoader as anything renderable by React.

Actual behaviour

TypeScript compilation fails because loadMinimalSizeand loadMinimalLoader are both declared as boolean types in index.d.ts.

How to reproduce it

N/A

retyui commented 5 years ago

This repo dead: https://github.com/leecade/react-native-swiper/issues/713