leecallen35
commented
2 years ago Thank you! Those compliments go straight to my heart.
The main change I would like to see is efficiency - making the program run faster. And the main area where I imagine there is a way to improve speed is the mymax() function. There must be a better way to find the maximum value from a list of objects.
I imagine some people would like the output in JSON format.
Sorry but I don't understand your question: I had questions and wanted to ask about the Companies listed in imports.
On Tue, Aug 9, 2022 at 3:22 PM Andrew Schell @.***> wrote:
What is @leecallen35 https://github.com/leecallen35 goal for this code, there are a few functions where I had questions and wanted to ask about the Companies listed in imports.
I agree with @Emotional_win that perhaps passing the parameters into the code would help, but also enable other integration of functions.
Perhaps we could use a main function and give the user different variables, different data sets to be passed in along with different currencies.
I like how detailed the code documentation is and encourage you to share more, this is pretty well written and yes there is always room for efficiency improvements but functionality to me is better than efficient but hard to read.
— Reply to this email directly, view it on GitHub https://github.com/leecallen35/find-SRs/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/APUQV7C4X2HCOUXXXJQFTTDVYKVYHANCNFSM56B43X5Q . You are receiving this because you were mentioned.Message ID: @.***>
-- Lee Allen email: @.*** bus: (716) 773-2729 m: (716) 880-0854
What is @leecallen35 goal for this code, there are a few functions where I had questions and wanted to ask about the Companies listed in imports.
I agree with @Emotional_win that perhaps passing the parameters into the code would help, but also enable other integration of functions.
Perhaps we could use a main function and give the user different variables, different data sets to be passed in along with different currencies.
I like how detailed the code documentation is and encourage you to share more, this is pretty well written and yes there is always room for efficiency improvements but functionality to me is better than efficient but hard to read.