search

leecheokfeng / pe

0 stars 0 forks source link

System error message displayed when non existent module is added (error handling) #5

Open leecheokfeng opened 2 years ago

leecheokfeng commented 2 years ago

image.png

Trying to add a non-existent module gives an API failed message. The next part then says 'Now adding CE2574 into timetable', but CE2574 is not an actual module and should not be added. This is followed by a 'java.lang.NullPointerException', which is a system error message that should not be shown to the user.

This bug happens after clearing the timetable.

soc-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

add module exception not handled

add course exception.png

add course exception 2.png

when module code is invalid, the module will be added and the raised exception is not handled

[original: nus-cs2113-AY2122S1/pe-interim#375] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Good catch, the program does not allow the use of invalid module code.

Downgrading of severity :

However, the team felt that this was a minor issue as the user guide was designed in a way that the search and show feature should be used to confirm the existence of the module before adding the module into your timetable. Therefore, is will only affect a small minority of users, as it is unlikely that an occurrence will affect the general functionality of this feature.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]