leecrossley / cordova-plugin-shake

Cordova / PhoneGap Plugin to detect when a physical device performs a shake gesture
http://ilee.co.uk
92 stars 33 forks source link

Make THRESHOLD a const #1

Closed mohsen1 closed 10 years ago

leecrossley commented 10 years ago

Thanks for your interest in the plugin @mohsen1, PhoneGap / Cordova has a really great community.

With regards to the pull request, I'm not sure it's adding anything, other than another variable. Also, the blank line at the top is intentional so that the Cordova CLI wraps the module a little nicer. These are personal preferences though :)

If you'd like to contribute, please add new features or fix bugs rather than modify coding style. Error handling would be a good place to start.

Thanks again!