search

leecrossley / cordova-plugin-shake

Cordova / PhoneGap Plugin to detect when a physical device performs a shake gesture
http://ilee.co.uk
92 stars 33 forks source link

Support for Cordova 9 #34

Closed r-guerin closed 4 years ago

r-guerin commented 5 years ago

Hi,

As you can see there https://github.com/arnesson/cordova-plugin-firebase/issues/1033 Cordova 9 deprecate the use of requireCordovaModule for non Cordova modules.

Would it be possible to make those changes please ?

remisture commented 5 years ago

I need this as well

ludufre commented 5 years ago

Me too

ludufre commented 5 years ago

I fixed and submitted PR #35

Ritzlgrmft commented 5 years ago

I merged the PR, thanks for it, @ludufre. @leecrossley: could you please publish a new version to npm?

In the meanwhile, you can add the plugin directly from https://github.com/leecrossley/cordova-plugin-shake.git.

remisture commented 5 years ago

Could someone please publish the latest version to npm?

ChrisTomAlx commented 5 years ago

Pretty please :)

FanYeeChok commented 4 years ago

waiting

ludufre commented 4 years ago

I fixed this problem on April 25th. And until today it was not published on npm. I think they abandon this project completely ...

ChrisTomAlx commented 4 years ago

I ended up forking and creating my own plugin on npm.. Really did not want to .. But no other option.. If it will help anyone else stumbling upon this.. Here you go.. https://www.npmjs.com/package/cordova-plugin-neushake

FanYeeChok commented 4 years ago

I ended up forking and creating my own plugin on npm.. Really did not want to .. But no other option.. If it will help anyone else stumbling upon this.. Here you go.. https://www.npmjs.com/package/cordova-plugin-neushake

No choice. Thanks anyway. Will it cause @ionic-native/shake unable to use if using your cordova-plugin-neushake ?

leecrossley commented 4 years ago

Published, apologies - https://www.npmjs.com/package/cordova-plugin-shake