search

leedo / noembed

oEmbed gateway service with additional non-oEmbed sources
http://www.noembed.com
481 stars 90 forks source link

Basic support for Gfycat #46

Closed brycied00d closed 9 years ago

brycied00d commented 9 years ago

While Gfycat does have an oembed endpoint ( http://gfycat.com/cajax/oembed/:id) it doesn't return any information, just an iframe in the html element (http://www.reddit.com/r/gfycat/comments/2kq4da/bug_gfycats_oembed_does_not_work_at_all/)

I hope to someday rewrite this provider to use http://gfycat.com/api to provide some more useful information and tighter integration.

leedo commented 9 years ago

Thanks! Been meaning to do this one.

brycied00d commented 9 years ago

Gave it a shot in the demo and it returns "missing url" - Any ideas? https://noembed.com/demo?url=http%3A%2F%2Fgfycat.com%2FCoordinatedHonorableGrunion

leedo commented 9 years ago

It looks like the TwitterCardProvider base class requires some specific Twitter related meta tags (url, description, title). So that base class could use some work to better handle a wider variety of content. Right now it's geared towards articles and not videos.

brycied00d commented 9 years ago

Excellent point - Gfycat has all of the meta tags except url, which explains the error. I'll see what I can hack together and I'll push to this pullreq.