leedrake5 / Russia-Ukraine

Equipment Loss Tracking
MIT License
617 stars 26 forks source link

Equipment gained or lost does not add up #6

Open yasonk opened 2 years ago

yasonk commented 2 years ago

I could be way off, but looks like the chart labeled "Equipment gained or lost" is not correct. It is showing 600 gain for Ukraine, but my rough calculation is closer to 300. Ukraine total lost equipement = 700. Ukraine captured roughly 1000. So total gain should be 1000-700 = 300.

qwertie commented 1 year ago

Yeah, it looks mighty suspicious, but I'm not familiar with R. Anyone who does know R want to look for mistakes over here?

leedrake5 commented 1 year ago

I think the discrepancy comes from adjusting for the captures.

Adjusted total = Country A total losses - Country A captures from Country B

To elaborate, all losses by Oryx (destroyed, captured, abandoned, or damaged) are real for Country A. But Country A has also captured some equipment from Country B, so this is discounted from their total, creating the adjusted total. Captures for that country are then measured against this adjustment. More simply put, both Russian and Ukrainian captures have to be factored for each country. I hope this helps to understand the calculation. @qwertie identified the relevant code - if you would prefer to adjust it you are welcome to give it a go.