leejo / cgi-fast

The new home for CGI::Fast, removing it from the original CGI.pm distribution
4 stars 5 forks source link

Make sure to use Carp before, er, using it #15

Closed melak closed 7 years ago

melak commented 7 years ago

Before:

$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ perl -Ilib -MCGI::Fast=socket_path,'/tmp/asdf',socket_perm,9876 -e 'CGI::Fast->new'
Undefined subroutine &CGI::Fast::croak called at lib/CGI/Fast.pm line 55.

After:

$ git checkout bugfix/use_cgi_carp
Switched to branch 'bugfix/use_cgi_carp'
$ perl -Ilib -MCGI::Fast=socket_path,'/tmp/asdf',socket_perm,9876 -e 'CGI::Fast->new'
[Thu Nov 17 19:03:35 2016] -e: Couldn't chmod(/tmp/asdf): Inappropriate file type or format at lib/CGI/Fast.pm line 55.
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3f6dc3cd47658a39140919ead7990dbd1826521a on melak:bugfix/use_cgi_carp into 5a01c14fa216339a28b7267d85a89e60cf9668e7 on leejo:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3f6dc3cd47658a39140919ead7990dbd1826521a on melak:bugfix/use_cgi_carp into 5a01c14fa216339a28b7267d85a89e60cf9668e7 on leejo:master.

leejo commented 7 years ago

Merged, ta! CI is failing because blead is failing to build, will look into that.

leejo commented 7 years ago

v2.11 on its way to CPAN, thanks again!

melak commented 7 years ago

Nice turnaround time :) Cheers, mate!