add support for socket perms

leejo / cgi-fast

The new home for CGI::Fast, removing it from the original CGI.pm distribution

4 stars 5 forks source link

add support for socket perms #9

Closed powerman closed 9 years ago

powerman commented 9 years ago

Implements #8

We probably should use croak instead of die, but this will need to 'use Carp' and you target at so old perl so I'm not sure is it ok to use it.
You may need to SKIP t/007_socket_perm.t on Win32 (I don't think it has UNIX Domain sockets).
It probably better to use File::Temp to generate socket name instead of using hardcoded 'fcgi.sock' and create it at module's root directory while testing, but, again, I wasn't sure is it ok to add extra dependency.

P.S. Looks like you should run make manifest - several files are missing.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling e9ba61405acc589d70663c18e7155d6cdd78a0ab on powerman:feature/socket_perm into 0cb4e6caeb9154d4fea68ae8a28c09be0c159a01 on leejo:master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling e9ba61405acc589d70663c18e7155d6cdd78a0ab on powerman:feature/socket_perm into 0cb4e6caeb9154d4fea68ae8a28c09be0c159a01 on leejo:master.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling e9ba61405acc589d70663c18e7155d6cdd78a0ab on powerman:feature/socket_perm into 0cb4e6caeb9154d4fea68ae8a28c09be0c159a01 on leejo:master.

leejo commented 9 years ago

Excellent, thanks. I shall merge this and make the additions as suggested.

leejo commented 9 years ago

K, v2.06 has just been sent to CPAN.

powerman commented 9 years ago

Thanks!