leekelleher / umbraco-contentment

Contentment for Umbraco - a state of happiness and satisfaction
https://marketplace.umbraco.com/package/umbraco.community.contentment
Mozilla Public License 2.0
155 stars 70 forks source link

Enable filter option doesn't seem to work #108

Closed bjarnef closed 3 years ago

bjarnef commented 3 years ago

What is the current behaviour?

I have upgraded Contentment to v1.4.2 and I noticed "Enable filter" has been added. It seems this is enabled by default when creating new pickers.

image

However I have some existing pickers where this in not enabled, but in both cases it seems to show the filter input above the item list in content section.

What is the expected behaviour?

I would expect the option "Enable filter" to wither show or hide filter input. I tried re-saving the datatype instances, but it didn't seem to have any effect.

Please tell us about your set-up:

leekelleher commented 3 years ago

@bjarnef Thanks for raising this. I've fixed it in commit 9feaa943fbb370e7a6d1d338ff6057e5cbab4d39, but that's currently in the v2.0 branch. If there are other small fixes then I'll consider doing a v1.4.3 patch release, (it's been a busy past week with all the v9 beta movement, not had time to consider anything else). 🙄

In the meantime, the workaround is to open the Item Picker options, toggle the "Enable filter" to whatever state you want, close the panel and save the DataType.

Note: Re-saving the DataType without touching the "Enable filter" option will not save the value, it's something to do with AngularJS not updating the model because the toggle's state had changed, I dunno. 🤷